Impulse convolver/guitarix

Programming applications for making music on Linux.

Moderators: MattKingUSA, khz

adegert
Established Member
Posts: 10
Joined: Sun Feb 21, 2010 12:45 pm

Re: Impulse convolver/guitarix

Post by adegert »

no you found something.. a bug ;-)
should be fixed in svn now. But be careful there's a lot of things changing atm so things might break. Preset format has changed, call the convert-* script in the tools directory to convert to the new format (this is non-destructive as the filenames have changed too).
User avatar
GarryO
Established Member
Posts: 167
Joined: Mon Apr 06, 2009 7:30 pm
Location: UK
Contact:

Re: Impulse convolver/guitarix

Post by GarryO »

svn@543 builds nicely.
Thanks for the heads-up: warning heeded!
Would you give a hint of what's changing ?
adegert
Established Member
Posts: 10
Joined: Sun Feb 21, 2010 12:45 pm

Re: Impulse convolver/guitarix

Post by adegert »

Not really visible things for the user... I'm changing parts of the internal structure how the parameters are represented and how they are saved, because in its previous form it was not very robust and blocking bigger changes. Then I have added some infrastructure so that dsp programs in the faust language can be embeded into the program. The dsp code in guitarix is not easily maintainable because its mostly generated by faust and then included into guitarix and then maybe changed afterwards, and I'd like to get back to the faust language. And then work on sound quality :D
User avatar
funkmuscle
Established Member
Posts: 2986
Joined: Mon Jun 02, 2008 2:30 pm
Has thanked: 197 times
Been thanked: 50 times

Re: Impulse convolver/guitarix

Post by funkmuscle »

can't wait to test that out!!!
sound quality, you mean getting a closer sound to real amps or just improving what's there already?
adegert
Established Member
Posts: 10
Joined: Sun Feb 21, 2010 12:45 pm

Re: Impulse convolver/guitarix

Post by adegert »

sadly I'm not an expert in amp modeling. From what I read I think the secret lies in clean implementation of the known principles and tweaking of parameters, e.g. the filtering before and after the nonlinear algorithms. But I don't know yet, we'll see.
User avatar
funkmuscle
Established Member
Posts: 2986
Joined: Mon Jun 02, 2008 2:30 pm
Has thanked: 197 times
Been thanked: 50 times

Re: Impulse convolver/guitarix

Post by funkmuscle »

hey guys, the latest svn revision 586 giving problems building.
this is the issue building it:

../src/gx_engine_audio.cpp:1965:34: error: faust-cc/compressor.cc: No such file or directory
../src/gx_engine_audio.cpp: In function ‘void gx_engine::registerVar(const char*, const char*, const char*, const char*, float*, float, float, float, float)’:
../src/gx_engine_audio.cpp:1931: warning: unused variable ‘fp’
Waf: Leaving directory `/home/harv/audio/guitarix/trunk/build'
Build failed
-> task failed (err #1):
{task: cxx gx_engine_audio.cpp -> gx_engine_audio_1.o}

@brummer:
the git version of rakarrack sounds awesome dude..
all I used was the Steve Harris LADSPA Valve emulator and the new IR Convolution module Model Amplifier cabinets with the IR files they supplied and the gain and tone was awesome with no noise gates. Very quiet..
Steve Harris LADSPA Valve emulator gives really great tube amp tones..
brummer

Re: Impulse convolver/guitarix

Post by brummer »

Hi

have add the missing files, . . .

guitarix is right now in a big restructure process, we go closer to faust http://faust.grame.fr/
adegert did a great job by rework some of my filters. It's in a testing state right now, I guess in some weeks
there will be some related changes in the guitarix engine. Right now, we (adegert) have make the switch to use zita-convolver as a inbuild convolution engine. Make sure you re-configure guitarix source befor build.

Great to hear there is a convolution module in rakarrack now, I haven't had the time to check it out (to much work at time) but will test it soon.
User avatar
funkmuscle
Established Member
Posts: 2986
Joined: Mon Jun 02, 2008 2:30 pm
Has thanked: 197 times
Been thanked: 50 times

Re: Impulse convolver/guitarix

Post by funkmuscle »

re-configure, how do I do that?
I get this:

$./waf configure --cxxflags='-O3 -march=athlon -Wall -std=c++0x' --prefix=/usr
Checking for program g++,c++ : ok /usr/bin/g++
Checking for program cpp : ok /usr/bin/cpp
Checking for program ar : ok /usr/bin/ar
Checking for program ranlib : ok /usr/bin/ranlib
Checking for g++ : ok
Checking for jack <= 1.8.0 : ok
Checking for sndfile >= 1.0.17 : ok
Checking for gthread-2.0 >= 2.10 : ok
Checking for gtk+-2.0 >= 2.12.0 : ok
Checking for sigc++-2.0 : ok
Checking for header zita-convolver.h : ok
Checking for header ladspa.h : ok
Checking for program faust : ok /usr/bin/faust
Checking for faust version : ok 0.9.9.4

==================
GUITARIX 0.07.0svn

C++ flags : -O3 -march=athlon -Wall -std=c++0x -O3 -DNDEBUG
Use faust : no
Install prefix : /usr
Install binary : /usr/bin
Install ladspa : /usr/lib/ladspa
Guitarix style directory : /usr/share/guitarix/skins
Guitarix builder directory : /usr/share/guitarix/builder
Guitarix pixmaps directory : /usr/share/pixmaps

'configure' finished successfully (4.466s)
brummer

Re: Impulse convolver/guitarix

Post by brummer »

your faust version is to old, . .

When you update your faust version, missing files in /faust-cc/ will produced by the faust- compiler.
In our SVN repository the next time it could often be that some off this files missing, because the ongoing work.
For us, the developers the advance of this is, we could work direct with the faust language to define filters and effects, we could plot them and analyse the mathematical correctness of the work.

My engine style befor becomes more and more chaotic and it geting harder and harder to find ops in the source. I have most filters and effects defined in faust language and clip the needed C++ parts to the guitarix engine, that's a lot work with many possible errors. Now that could be done automatic. :)
With the new changes adegert have make, we could start to find better solutions with simple small edits in faust files and it will be easy to read the engine source.

In releases we will take care that faust isn't needed to build guitarix, but for the SVN repository it becomes more and more relevance.

The changes in the engine are mostly not active for now, that's what I mean with testing, there is a switch to switch between old/new engine, next time we switch complete to the new one.

Anyway, yea I mean configure the source new to check the new dependencies and write the new config header file to make sure all needed files will find prop. Did it build now ?
adegert
Established Member
Posts: 10
Joined: Sun Feb 21, 2010 12:45 pm

Re: Impulse convolver/guitarix

Post by adegert »

funkmuscle wrote:hey guys, the latest svn revision 586 giving problems building.
this is the issue building it:

../src/gx_engine_audio.cpp:1965:34: error: faust-cc/compressor.cc: No such file or directory
sorry forgot to put it into svn...
funkmuscle wrote: @brummer:
the git version of rakarrack sounds awesome dude..
all I used was the Steve Harris LADSPA Valve emulator and the new IR Convolution module Model Amplifier cabinets with the IR files they supplied and the gain and tone was awesome with no noise gates. Very quiet..
Steve Harris LADSPA Valve emulator gives really great tube amp tones..
swh plugins are generally quite good.. i have the dsp code in faust now but no time to test yet..
I think you need several valve plugins in series with an inverter or so to get some more realistic distortion.
(the nonlinear part seems to be from some master thesis that i can't find on the net :-|)
User avatar
funkmuscle
Established Member
Posts: 2986
Joined: Mon Jun 02, 2008 2:30 pm
Has thanked: 197 times
Been thanked: 50 times

Re: Impulse convolver/guitarix

Post by funkmuscle »

yeah, I forgot to update faust. done now but I get this:

find_or_declare returns a build node, not a source nor a directory ['AntiAlias.cc']
adegert
Established Member
Posts: 10
Joined: Sun Feb 21, 2010 12:45 pm

Re: Impulse convolver/guitarix

Post by adegert »

funkmuscle wrote:find_or_declare returns a build node, not a source nor a directory ['AntiAlias.cc']
did you use the waf version from the trunk directory? you should configure with something like

./waf configure --debug

(I just validated it with a freshly checked out tree)

If you can get it to work i'd like to get some feedback if you find any differences between old and new engine (you can switch to old engine with Shift-F5, there should be a log message, but be sure to configure with --debug). Preamp should be different (and osc tube when oversampling), but all other things should sound like the old version. This is just some cleanup, but after the we'd like to make some bigger changes...

Btw. there might be some problems with denormals (e.g. high cpu load when connected to silent source) which should go away when you add -mfpmath=sse to the flags in --cxxflags-debug.
User avatar
funkmuscle
Established Member
Posts: 2986
Joined: Mon Jun 02, 2008 2:30 pm
Has thanked: 197 times
Been thanked: 50 times

Re: Impulse convolver/guitarix

Post by funkmuscle »

I get this now:
find_or_declare returns a build node, not a source nor a directory ['preamp.cc']

the waf I'm using is the one on my system which has been working for the builds..python-waf 1.5.14

I cd to trunk and run ./waf from there....
adegert
Established Member
Posts: 10
Joined: Sun Feb 21, 2010 12:45 pm

Re: Impulse convolver/guitarix

Post by adegert »

its a bug in waf 1.5.14; version 1.5.14a should be ok

but if there are any problems, you should first try the waf version delivered with the sources.
User avatar
funkmuscle
Established Member
Posts: 2986
Joined: Mon Jun 02, 2008 2:30 pm
Has thanked: 197 times
Been thanked: 50 times

Re: Impulse convolver/guitarix

Post by funkmuscle »

version 1.5.14a installed and running.. built for tarball.
still:
ind_or_declare returns a build node, not a source nor a directory ['preamp.cc']
Post Reply