Impulse convolver/guitarix

[brummer]

What about making the jconv section separate so mulitple IR amp/cab files can be loaded? I do that already with the command line but a cool gui, especially one that looks like a cab as in GuitaRig and Amplitube, would rock.

The same here as for a possible bass amp breakout, everybody is welcome to grape the source and make it, as long as the result is again open Source.

I be willing to help out there and answer all upcoming questions, but at least, my main Interest is the guitarix project, and there is a lot stuff to do, befor we could reach version 1.0
Thanks to thorgal the development going smart and fast,
but anyway, there are some milestones to clime.

Enable multi IR file loading is a nice suggestion, I will think about that, may it comes handy in a "change on the fly " style also.

[GarryO]

I didn't see the problems Funkmuscle was having with svn@341, but I'm getting crashes with svn@342.
If jconv was running when guitarix is closed, it crashes on startup.
qjackctl's connections window (usually) shows the ports being created, then guitarix aborts.
It starts up fine if jconv was _not_ running previously.

I like the jconv gain knob: it makes it that bit quicker and easier to tweak your sound.
But the dual meter confused me for a short while until I worked it out.
It might be an idea to label the meters? Its obvious once you know, but maybe confusing to new users?

I meant to mention it earlier, and was reminded by Dave's comments on the other thread:
it would be nice to have a "target line" in the tuner window to mark the right pitch.

all the best guys.

[brummer]

I didn't see the problems Funkmuscle was having with svn@341, but I'm getting crashes with svn@342.
If jconv was running when guitarix is closed, it crashes on startup.

Oh, yes, okay have send a quick fix for that, but it need some more test to adjust the startup sequence for this case. Let us know if the fix work (stable)

But the dual meter confused me for a short while until I worked it out.
It might be an idea to label the meters?

Yea, we do that

brummer

[GarryO]

svn@344: same behaviour: crash if jconv was running, ok if not.

[brummer]

mmm, okay, one more try, svn@345 startup fine again here, connected and with jconv running.

EDIT:// no, didn't startup stable, need to investigate here. Please start guitarix without jconv runing in the mean time, we let you know when we have fix it.

[thorgal]

hi guys,

I finished the jack port map.

svn@348

when you launch guitarix, use Shift+P to make the portmap window popup, same to hide it (or use your mouse as usual).

Launch any jack clients, see how the map works. Use 't' to cycle through the client tabs.

It is rock solid for me. Hope it is for you
The portmap is really resilient, meaning that guitarix will not suffer from a jack shutdown or disconnection. The map just follows what is going on at the jack server level and simply provides the current state of things. Enjoy

[funkmuscle]

hey guys, here is an example of a vst that's like guitarix.
notice the 2 cabinets with IR files loaded in them. The look of a real amp and cab.
just a suggestion for down the road. Just for a more authentic amp look. at the guitar forums, that's a major deal with vst.
http://1.bp.blogspot.com/_ymy2TIpgMYc/S ... lStack.jpg

edit:

also, can you get guitarix to sound like this:
http://dl.getdropbox.com/u/1393938/RELE ... hogger.mp3
the example is not me or guitarix, it's LePou Plugin LE456 which is a vst guitar preamp driving IR files.

I did at one point get a sound like that with guitarix and IR files. Can't get it anymore.

[thorgal]

hey funkmuscle.

haha, I cannot help smiling when I see all this. I will tell you one thing:

I mainly code in guitarix for myself

I am sharing the code with the community because it is under GPL and it looks like it is of good support for brummer's work as well. I won't be the guy doing what you suggest because I have no interest in this, sorry man. I would think you could try and learn to code in C / C++ and contribute to guitarix. But personally, I have no concern whether the app will be a success or not in the guitar community you mention (or others). I confess a very egoistic use and development of this app, as far as I am concerned

I only speak for myself. brummer may have another opinion, but I think he expects ppl just like him or me to join in and have fun in developing the app in no particular order. Maybe you can attract some graphics designers and convince them to join in ? I am more interested in the UI part, and especially forgetting about the graphics as much as possible (not 100% possible but I am trying, that's the reason I implemented a lot of keyboard shortcuts in the first place ). The level display was because I needed something of the kind. It will improve soon as well. I have a few other things on my personal TODO list for this app that follow no agenda other than my own. That's the beauty of open-source

By the way, I could definitely go and isolate the jconv widgets and call that e.g. gconv. If I find it useful, I may do that at some point, unless someone else volunteers to do it I actually wanted to hack into libzita in the first place but F.Adriaensen is always saying that the API will change without any notice (remains to be checked though).

For the sound, brummer has to repeat what he's up to. guitarix is no convolver but a modeller. jconv is only supported as a commodity because someone found it useful (him I guess). So, being a modelling app by essence, what you ask is beyond the scope. What you want seems to be a convolver with an attractive GUI that reminds of what the IR was coming from (AMP, cabinets, etc). That's another project in itself.

[funkmuscle]

hey thorgal, like I said, maybe down the road on the gui side...
the sound sample I sent you, I said I created something close to it with guitarix and IR files but I can't anymore.
I only use guitarix with jconv because it sounds like a real amp only when using IR file IMHO.

I wish I had the time to learn all the C++ etc. I don't even have time to have fun and test guitarix like I did before.

all good though. keep up the great work becuase in the end, who cares what it looks like, as long as it rocks..

[thorgal]

hey thorgal, like I said, maybe down the road on the gui side...

who knows ?

the sound sample I sent you, I said I created something close to it with guitarix and IR files but I can't anymore.

since when ? is it a guitarix change or a tweak in jconv or an IR file problem ? I know brummer has ben fiddling with the different audio stages in guitarix. But without your input, it would be hard to find out what the culprit can be.

I only use guitarix with jconv because it sounds like a real amp only when using IR file IMHO.

so what you need is not guitarix but a GUI for jconv. Someone will have to take on the job to understand libzita and work out an app around the API, however temporary it is. I don't believe F.Adriaensen is about to work on this any time soon but who knows what his agenda is ? If I had more time, I could do it but yeah, time is precious, as you know every well

I wish I had the time to learn all the C++ etc. I don't even have time to have fun and test guitarix like I did before.

what happened ? a change in your daily life ? a demanding job ? I will become a father in a few months, that's also for a real life change
It will also mean that I won't be free and available for a while ...

all good though. keep up the great work becuase in the end, who cares what it looks like, as long as it rocks..

yeah

[funkmuscle]

@thorgal
congrats dude... a new dad... trust me. best feeling in the world being a dad.

Hey, started to muck around with guitarix and I'm getting the tones I like again.
I remembered brummer saying to launch jconv from the command line and connect guitarix to it.
that works.

time is short for me yes due to work.

[brummer]

svn@344: same behaviour: crash if jconv was running, ok if not.

fixed now, svn@349

[GarryO]

Hi, guys. Re svn@351

@Thorgal : jack ports widget works fine barring one minor glitch: the ports tab created for an external app doesn't go away when the app does. Consequently an additional set of ports is created when that app is restarted.
Apart from that works great. And is looking good too.
Another trivial thing: the alsa ice1712 driver provides 12 capture + 10 playback ports, even though my delta44 only has 4 of each. The system ports tab lists these as: capture1, capture10, capture11, capture12, capture2, capture3 ...

@Brummer, no more problems with jconv confirmed!

Keep up the good work guys. I sometimes have the niggling feeling that all I do is nitpick - its not my app after all - but I think Guitarix is a great piece of software and I appreciate you guys sharing it.

all the best, G.

[thorgal]

hey Garry,

The symptom you are describing (tab still visible) should not at all exist. Which app are you seeing doing so ? The portmap is based on the jack server callbacks. I noticed that some clients do not unregister their ports when exiting (which I can work around) but worse, if some do not unregister as clients at all, there could be an issue as I expect jackd to tell guitarix when a client leaves, through a callback function. So which client did fuck up ? I had not seen this behavior on my PC.

About the port sorting, this is also something inherited from jackd: that's how jackd delivers the port list to client. Since names can vary a lot from client to client, it is impossible to make a generic sorting. However, I can code an exception for the "system" client. I too have a lot of system IOs so I can definitely sort this out for "system" (cosmetic but details can sometimes count).

[GarryO]

The external app I was using was Linuxdsp's stereo reverb. I was using this for the sake of testing only, simply because its easy to hear if its working. I would not normally use external apps at all with Guitarix.
BTW,I also tried Tapreverbed, which crashed Guitarix, but IIRC its not realtime safe.
perhaps I should try some others.

re port sorting: I really don't think this is a big deal. But if you can sort it for the "system" tab I think that will cover 99.99% of cases. The only external app that is going to have any significant number of inputs/outputs is Ardour, and they tend to come in pairs anyway, so not a problem.

I did wonder if It was worth handling external apps at all ( jconv included, seeing as the port handling for that works fine as is). With external apps you are gonna have to connect their outputs via qjackctl or patchage whatever anyway. What's your thinking on this? Where do you see the advantage?