LinuxMusicians

Hi, Brummer, Thorgal. sorry if I'm bit slow posting back.

svn314:
The jack dis/connect feature works perfectly here. No problems.
Peak cpu use is around 8% ( 32bit athlon 2800+ ), adding fx adds little more to that. That's very useful eye-candy, Thorgal!

one problem: switching in tube2 now gives me a kind of slapback echo/reverb effect ( no fx turned on).
I have to say I think svn313 sounded better - pretty sweet in fact. 314 sounds thinner and harsher to my ear.

all the best, guys.

Hi Garry,

I cannot say about the sound difference you are experiencing. brummer is the one responsible for the sound modelling. I mainly fiddle around with the UI.

Try svn@315 and see if it does not crash. You will have to reconfigure (./waf configure) as I added a couple of more png files that displays the jack connection status.

The level display is still very experimental and hackish. I need to sort out a few things. At very low latency, the left and right channels do not display consistent levels. This is due to some concurrency stuff between jack and X. I will sort this out eventually.

Hi, Thorgal. svn@315 locked up solid the first time I ran it, the audio engine was working but the gui was totally unresponsive. The second and subsequent times it ran but then crashed and vanished. This seemed to occur when the meter hit full-scale ( or very near): it ran fine up to that point.

unexpected stuff ...

try svn@316. I changed a few things. Not there yet but close. This version should not crash as it is gentle on the display.


You do have to
Thanks for reporting.

Unfortunately I see the same behaviour in svn@316 too.

sounds like a big segfault (memory violation). I'll try to have a look when I have time (still at work right now ...)

OK, fixed it it was actually easy and fast.

svn@317

EDIT: ah no, not quite ... still an issue ... let me get back to it ...
EDIT2: svn@319, seems stable.

I had a spare hour to hack a bit more into it.

I changed the layout and fixed some little issues. Try svn@321.

I've only given svn@321 a quick test so far ( it's been a tough day, I'm whacked) but ...
No crashes! I can't reproduce the previous failures.
I really like the revised layout: more compact and unobtrusive without losing anything. Nice work.
One minor niggle I've been meaning to mention: to close an fx settings window you have to re-click the little light-up button on the main panel; clicking the window-close button doesn't work ( although the minimize button does). This is kinda driving me nuts because my reflex action is to go for the window-close button everytime. Any chance that could be fixed?

hey Garry,

Glad it's stable again

I checked in an extra little change, now the scale is in dB, from -40dB to +6dB.

green is from -40dB to -10dB
yellow is from -10dB to 0dB
red is from 0dB to +6dB

I tried to find a compromise for the CPU usage of the display thread and minimized the amount of element "X refresh" as much as I could. There may be room for further optimization though.

I'll see what I can do about the issue you mentioned.

EDIT: had a look at the nagging button thing. I will have to undo some of brummer's original code to achieve such a simple thing. He disabled the normal window deletion on purpose due to his import of a "special" GTK class. It is not that hard to hack around but I will need some time to figure out this "old" code without breaking stuff. I hope you can live with it for now.

Hi guys,

I found the time to complete the interaction with the jack server.
I had to reshuffle some code, especially how the engine interacts with the GUI.

I managed to get some quite interesting stuff:

- you can start guitarix without jack
- as soon as you start jack, guitarix will connect automatically
- you can shut jack down and guitarix will stay alive, just waiting for jack to come back
- or you can reactivate it from guitarix with Shift +C.

I tested it but did not have time to fully test all corner cases (when e.g. meterbridge is on, etc).
The guitarix setting file is too primitive as of now to recall the exact same setting (e.g. when jconv was on and jack died, guitarix will not come back automatically with jconv but jconv is just one click away anyway ).

Please try to toy around with this when you have time and report anything odd (or praise me if you like ).

svn@324

oh yeah, expand the guitarix log message window to have some useful realtime info

HI, Thorgal.
I already checked out svn@324 before you posted! And found no problems.
I'll have a good look at your new features tomorrow.
Re the window close thing: its no big deal, just one of those fine details that might cause a little frustration.

May the Sun shine eternally upon you and yours,
and may your coding talents bring you great rewards!

all the best, G.

here's what I found testing svn@324 - in all cases I'm starting Guitarix with in & out connections specified on the command line:

1) starting Guitarix with jack not running: starts ok,
select "start jack" from dialogue box, jack starts, connections made ok.

I guess this would cover most situations ( dagnammit i forgot to start jack! ) but your corner cases...

2) starting Guitarix with jack not running:
select "ignore jack" from dialogue, Guitarix waits ok.
do shift-c then select "start jack" starts jack ( qjackctl actually ) but connections not made,
though the ports appear in the qjackctl connections panel.

3) if you are perverse enough to go through the "ignore jack" stage twice, then "start jack",
Guitarix aborts. I guess I'm perverse.

4) starting Guitarix with jack not running: select "ignore jack", meterbridge obviously won't start,
warning given to start jack first. ok.
shift-c starts jack, but Guitarix aborts most times, occasionally doesn't.
meterbridge remains ticked as enabled in the menu. selecting meterbridge from menu twice,
disable then enable, meterbridge starts ok.
( note to self: it's spelt metre actually: you're English, so spell it the French way! )

5) With Guitarix running and connected to jack, killing jack outside Guitarix, Guitarix waits ok,
jack status widget shows red. Shift-c starts jack, but connections not made, as in 2) above.

6) killing jack with meterbridge running kills meter but Guitarix just waits.
restarting jack, Guitarix shows meterbridge enabled in menu ( but no meterbridge)
selecting meter 2x ( disable then enable) starts meter.
Meter connections made ok, but not Guitarix audio connections.

7) killing jack with jconv running, kills jconv, jconv is shown disabled, restarting results as 2) above.

BTW i'm running jack 0.116.2+svn3592-3 and qjackctl 0.3.4-1 which are the current Debian/testing versions.

Hope I didn't spoil your day too badly, James, old bean! Keep on keeping on!
( Thorgal : I assumed you were Norwegian initially! )

All the best, G.

Hi Garry,

Thanks for the feedback. I fixed a small race condition issue which sometimes made guitarix abort at startup. I've committed the change to svn.

I will correct the meterbridge mess. There's something else there that's been buggy for a while.

I also have a few more goodies in the making, I'll let you know

Cheers!

Hi

nice to come back and see such nice stuff done.
So it's a fun to work on. . .
Then I have enable the little X button for the settings widgets to be used for windows closing.
Have replace the level display near the gain controllers, add a scrolled area with 50 lines to the log widget, and add the reconnect to the last used ports when connect back to the jack server.

@garry, I guess the prob with tube2 is gone ? I haven't change the audio engine since rev@312

brummer