Yoshimi - testers wanted

[Linuxmusician01]

[...] the latest build supports a fairly complete theme colour control [...]

Is that version 2.2.0 from the homepage or the "master" version from Github?

[edit]
Built the ver from Github: it has the theme option.

[folderol]

Yes, the more detailed filter control arrived after that..
This seems like exactly the same issue, so this time you need to add that line in src/Effects/EffectMgr.h

In a sense this is good news to me. Your system seems to be especially pedantic for some reason, but other people's might also be. I'll make sure in the next commit we are being more squeaky clean.

Still not enough:

Code: Select all

[ 10%] Building CXX object CMakeFiles/yoshimi.dir/Interface/InterChange.cpp.o
In file included from /tmp/yoshimi/src/Effects/EffectMgr.h:40:0,
                 from /tmp/yoshimi/src/Interface/InterChange.cpp:52:
/tmp/yoshimi/src/Effects/EQ.h: In constructor ‘EQ::FilterParam::FilterParam(SynthEngine&)’:
/tmp/yoshimi/src/Effects/EQ.h:76:47: error: ‘TOPLEVEL::filter’ is not a class, namespace, or enumeration
                 ,l{new AnalogFilter(TOPLEVEL::filter::Peak2, 1000.0, 1.0, 0, &synth)}
                                               ^
compilation terminated due to -Wfatal-errors.

I am afraid that's not the single cause.

Shall I go back in time to some specific commits?

Actually, I don't think that will help. It's clearly associated with us converting the filter 'magic number' to a named constant (we've been slowly getting rid of anonymous numbers), but I don't understand how that one is being rejected when it's in exactly the same file as all the others. Also, I'm not seeing this on three quite different machines - admittedly all with fairly up-to-date devuan. Nobody else seems to have this problem either, so it does look like there is some issue either with the compiler, or maybe cmake. That's no help to you of course.

[folderol]

It's 'master' from either github or sourceforge (I keep them in sync).

[Linuxmusician01]

It compiled on Ubuntu 20.04 when I followed the instructions in the text file called "INSTALL". Does anybody have theme files? I tried the one called "demo.clr" in the dir '/yoshimi-master/doc/examples/themes/' but it hurts my eyes more than the classic theme.

[folderol]

Well, it was intended to demo just how extremely you can change the appearance
Why not make a copy of the one that closest to your liking and edit that?
Oh, and the latest commit a few minutes ago has the rounded buttons.
I think there's only three more colour settings that might be added to the end of the file at some point.
Currently I'm working through all the knobs, getting their pointers to change colour if not at the default setting - like the sliders do. It's not difficult - just tedious

[bluebell]

Yes, the more detailed filter control arrived after that..
This seems like exactly the same issue, so this time you need to add that line in src/Effects/EffectMgr.h

In a sense this is good news to me. Your system seems to be especially pedantic for some reason, but other people's might also be. I'll make sure in the next commit we are being more squeaky clean.

Still not enough:

Code: Select all

[ 10%] Building CXX object CMakeFiles/yoshimi.dir/Interface/InterChange.cpp.o
In file included from /tmp/yoshimi/src/Effects/EffectMgr.h:40:0,
                 from /tmp/yoshimi/src/Interface/InterChange.cpp:52:
/tmp/yoshimi/src/Effects/EQ.h: In constructor ‘EQ::FilterParam::FilterParam(SynthEngine&)’:
/tmp/yoshimi/src/Effects/EQ.h:76:47: error: ‘TOPLEVEL::filter’ is not a class, namespace, or enumeration
                 ,l{new AnalogFilter(TOPLEVEL::filter::Peak2, 1000.0, 1.0, 0, &synth)}
                                               ^
compilation terminated due to -Wfatal-errors.

I am afraid that's not the single cause.

Shall I go back in time to some specific commits?

Actually, I don't think that will help. It's clearly associated with us converting the filter 'magic number' to a named constant (we've been slowly getting rid of anonymous numbers), but I don't understand how that one is being rejected when it's in exactly the same file as all the others. Also, I'm not seeing this on three quite different machines - admittedly all with fairly up-to-date devuan. Nobody else seems to have this problem either, so it does look like there is some issue either with the compiler, or maybe cmake. That's no help to you of course.

I made further investigations. The latest version that builds on my machine is 842422705ee949bde486221cdee96d148d04c741 (Updated docs, Set release version 2.2.3)

The following commit a36c4dd2902723e9ea51350424fc616cf5409ddf (From Jesper, Added copy_if_different step to fltk source generation to speed up rebuilds) breaks it.

Does this help?

[folderol]

Thanks a LOT for that investigation. Yes that is very important
We mustn't include that in commits for the time being. I'll change it back in the next commit, but to prove the point, with the failing version, can you rename /yoshimi-code/src/CMakeLists.txt
to something else, then copy in the version from the last build that worked.
You'll probably then have to do a make clean, and go though the build process again.

[bluebell]

Thanks a LOT for that investigation. Yes that is very important
We mustn't include that in commits for the time being. I'll change it back in the next commit, but to prove the point, with the failing version, can you rename /yoshimi-code/src/CMakeLists.txt
to something else, then copy in the version from the last build that worked.
You'll probably then have to do a make clean, and go though the build process again.

Code: Select all

git clone https://github.com/Yoshimi/yoshimi.git
cd yoshimi/
cd src/
mv CMakeLists.txt CMakeLists.txt.orig
cp /home/hm/src/yoshimi/yoshimi_2.2.3/src/CMakeLists.txt .
mkdir build
cd build/
ccmake ../src/
make

The CMakeLists are not that different when neglecting slightly different indented/formatted lines:

hm@bubu:/tmp/yoshimi/src$ diff CMakeLists.txt*

Code: Select all

5c5
< #   Copyright 2014-2021, Will Godfrey & others
---
#   Copyright 2014-2023, Will Godfrey & others
48,51c48,51
< #add_definitions(-Wfatal-errors) # stop on first
< #add_definitions(-Werror=format-security)
< #add_definitions(-Wextra)
< #add_definitions(-Wno-vla) # Nothing wrong with variable length arrays
---
add_definitions(-Wfatal-errors) # stop on first
add_definitions(-Werror=format-security)
add_definitions(-Wextra)
add_definitions(-Wno-vla) # Nothing wrong with variable length arrays
54c54
< set (YOSHIMI_VERSION "2.2.3")
---
set (YOSHIMI_VERSION "2.2.3 M")
138c138
<     CACHE STRING "basic compilier options"
---
    CACHE STRING "basic compiler options"
344a345,347
    set (guitmp generated-gui-sources)
    file (MAKE_DIRECTORY "${CMAKE_BINARY_DIR}/${guitmp}")

353,355c356,361
<             OUTPUT ${sourcefile}
<             COMMAND ${FLTK_FLUID_EXECUTABLE} ARGS -c -o .cpp ${fluidfile}
<             DEPENDS ${fluidfile}
---
          OUTPUT ${sourcefile}
          WORKING_DIRECTORY ${guitmp}
          COMMAND ${FLTK_FLUID_EXECUTABLE} ARGS -c -o .cpp ${fluidfile}
          COMMAND ${CMAKE_COMMAND} ARGS -E copy_if_different ${sourcefile} ..
          COMMAND ${CMAKE_COMMAND} ARGS -E copy_if_different ${headerfile} ..
          DEPENDS ${fluidfile}

Unfortunately the build process stops as well:

With the copied CMakeLists from 2.2.3:

make_output.txt

(10.91 KiB) Downloaded 45 times

With the original CMakeLists from git clone:

make_output_with_orig_CmakeList.txt

(2.91 KiB) Downloaded 40 times

[Largos]

Got a build with the further updated link buttons, they are much nicer.

Is there a way in the theme to change the outline of the slider, it's dark which is fine for a light background but it blends in the background of a dark theme?

Screenshot_20230407_155405.png (402 Bytes) Viewed 973 times

[folderol]

Try reversing the grayscale. eg. 120,0 instead of 0,120

[folderol]

Thanks a LOT for that investigation. Yes that is very important
We mustn't include that in commits for the time being. I'll change it back in the next commit, but to prove the point, with the failing version, can you rename /yoshimi-code/src/CMakeLists.txt
to something else, then copy in the version from the last build that worked.
You'll probably then have to do a make clean, and go though the build process again.

Code: Select all

git clone https://github.com/Yoshimi/yoshimi.git
cd yoshimi/
cd src/
mv CMakeLists.txt CMakeLists.txt.orig
cp /home/hm/src/yoshimi/yoshimi_2.2.3/src/CMakeLists.txt .
mkdir build
cd build/
ccmake ../src/
make

The CMakeLists are not that different when neglecting slightly different indented/formatted lines:

Damn! I thought we'd got it. I'll have to take a look through those commits and see what else might have changed.
A last ditch possibility is to nuke the whole of the build directory and start again as if it was a completely new git clone.
In the past I've had to do that on very rare occasions.

[folderol]

Just to add that this was a red herring, as this is the commit where named filters were introduced.
Almost all use of this is in effects, and each one has a proper include of analog filter which in turn includes globals.h so everything should have inherited it.

However, in the next commit I'll directly include it in all of them - even though it shouldn't be necessary!

[folderol]

More knobs recognise the default position, and hopefully the problem bluebell was having is fixed.
P.S. there are a lot of knobs

[Linuxmusician01]

Well, it was intended to demo just how extremely you can change the appearance
Why not make a copy of the one that closest to your liking and edit that?
Oh, and the latest commit a few minutes ago has the rounded buttons.
I think there's only three more colour settings that might be added to the end of the file at some point.
Currently I'm working through all the knobs, getting their pointers to change colour if not at the default setting - like the sliders do. It's not difficult - just tedious

Thanks for the info. I could only find one example in the source code tree. Maybe I'm looking in the wrong dir. Gonna compile that latest version you're talking about.

Good luck with developing this great synth!

[bluebell]

More knobs recognise the default position, and hopefully the problem bluebell was having is fixed.
P.S. there are a lot of knobs

Unfortunately not yet:

Code: Select all

[  0%] Building CXX object CMakeFiles/yoshimi.dir/Interface/InterChange.cpp.o
In file included from /tmp/yoshimi/src/Effects/EffectMgr.h:38:0,
                 from /tmp/yoshimi/src/Interface/InterChange.cpp:52:
/tmp/yoshimi/src/Effects/EQ.h: In constructor ‘EQ::FilterParam::FilterParam(SynthEngine&)’:
/tmp/yoshimi/src/Effects/EQ.h:75:47: error: ‘TOPLEVEL::filter’ is not a class, namespace, or enumeration
                 ,l{new AnalogFilter(TOPLEVEL::filter::Peak2, 1000.0, 1.0, 0, &synth)}
                                               ^
compilation terminated due to -Wfatal-errors.