suggestions for and questions about Guitarix

[studio32]

What is the exact name of the package? Are you sure 2.14 is in the backports and not 2.12?

[brummer]

if you cant upgrade your GTK installation to 2.14, you could only use guitarix up to version 0.04.6-1

[brummer]

Hi

Good news for stable users, we receive a patch from James Morris to build guitarix against Gtk+2.12
It's applied revisited in SVN rev@419

brummer

[thorgal]

I just saw the patch. Fine for debian stable but I would suggest we keep the code for newer version as well with some preproc macros ("if gtk_version < 2.14 -> do this else -> do that")

As you know brummer, I have no more time for this. So could you make sure you include some preproc macros so that we can compile the original code if waf detects a gtk version >= 2.14 ?

Should not be too difficult

[brummer]

The only real prob was

Code: Select all

gtk_menu_get_accel_path

the empty string James suggested didn't work, but I replace (get/set) with

Code: Select all

gtk_widget_add_accelerator (menu_widget, "activate", gx_gui::GxMainInterface::instance()->fAccelGroup,
                              accel_key, list_mod[i], GTK_ACCEL_VISIBLE);

btw. : list_mod[lindex]

That work with GTK+2.12 and greater.
For now I have only comment out our old code and replace it with the "new" version. I experience no prob with it,
and if noon reported we don't need a switch for it.

Anyway, I guess sooner or later we need some macros for that behave.

EDIT://
so. report the bug by myself,
I have switch back to use the accelerator_path, I have just replace gtk_menu_get_accel_path with a own wrote routine. Now it work like suspected.
brummer