Guitarix MIDI Output -> MIDI Foot Controller

All your LV2 and LADSPA goodness and more.

Moderators: MattKingUSA, khz

arman
Established Member
Posts: 16
Joined: Tue May 05, 2020 9:16 pm

Guitarix MIDI Output -> MIDI Foot Controller

Post by arman »

Is there a way to setup Guitarix such that when an effect is turned on, the midi controller hardware receives the signal? I want my foot controller to lightup based on what effects are on in a preset. Currently it is only unidirectional - the controller can send Guitarix messages.

tramp
Established Member
Posts: 1616
Joined: Mon Jul 01, 2013 8:13 am

Re: Guitarix MIDI Output -> MIDI Foot Controller

Post by tramp »

Currently not, only program change messages been forwarded right now. We think about to include on/off messages to that as we've received a couple of requests for that feature.
On the road again.

tramp
Established Member
Posts: 1616
Joined: Mon Jul 01, 2013 8:13 am

Re: Guitarix MIDI Output -> MIDI Foot Controller

Post by tramp »

I've just pushed to our git repository's, the option to send feedback to midi controllers when a value changed while it is connected to a controller.
So your Midi controller will be able to reflect the state of guitarix effects.
On the road again.

arman
Established Member
Posts: 16
Joined: Tue May 05, 2020 9:16 pm

Re: Guitarix MIDI Output -> MIDI Foot Controller

Post by arman »

awesome! I'll give this a try soon

arman
Established Member
Posts: 16
Joined: Tue May 05, 2020 9:16 pm

Re: Guitarix MIDI Output -> MIDI Foot Controller

Post by arman »

Finally got the latest version from git installed. Where can I find that option?

tramp
Established Member
Posts: 1616
Joined: Mon Jul 01, 2013 8:13 am

Re: Guitarix MIDI Output -> MIDI Foot Controller

Post by tramp »

It's under the "Options" menu, a check menu entry "Send Midi Feedback".
On the road again.

arman
Established Member
Posts: 16
Joined: Tue May 05, 2020 9:16 pm

Re: Guitarix MIDI Output -> MIDI Foot Controller

Post by arman »

Ah ok, I see what it is doing via midi monitor. It should be working but perhaps my footcontroller (Midi Commander) isn't able to receive messages (though it does show up as an output in guitarix and jack)..

I think the root of the problem is Midi Commander always sends an alternating CC value of 0 or 127 even when one of the PC switches is pressed. When a PC switch is pressed, the CC switch's light turns off. Here is an example problematic flow:
suppose a distortion is controlled with cc1 and is off in both preset 1 and 2 by default.
Hit cc 1 value 127 is sent, light is on (distortion on - good)
Hit pc 2, the previous cc switch's light is now off (distortion off - good)
Hit cc 1 again, but now 0 is is sent, light is still off.. (distortion still off - huh?)
Hit cc 1, 127 sent. Light is on (distortion on - OK..)

As you can see in step 3 & 4, I am having to double tap to reset the switch which can be very confusing in a performance -had I not touched the cc switch before changing patches, it would be a single tap.

Anyways, I am OK with ignoring the lights on my controller, but am wondering if in Guitarix there is a way for a CC message to *always* toggle an effect, regardless of value 0 or 127 etc?

tramp
Established Member
Posts: 1616
Joined: Mon Jul 01, 2013 8:13 am

Re: Guitarix MIDI Output -> MIDI Foot Controller

Post by tramp »

Ah, okay got it.
I've implemented a new toggle state now, called "always toggle", this will toggle the state on any signal, regardless the value.
Please update your checkout and check if that is what you need.
On the road again.

arman
Established Member
Posts: 16
Joined: Tue May 05, 2020 9:16 pm

Re: Guitarix MIDI Output -> MIDI Foot Controller

Post by arman »

"always toggle" solves the double clicking problem but requires the effect to be saved in the opposite of the desired state. So if you want the effect to start off when the preset is switched to, you must save it in the on state and vice versa. In other words, "always toggle" seems to toggle the state for a preset change.

Also, if this quirk is fixed I think this would actually be the only midi setting of the four that makes sense. I can't see a case where a user would want to hit their midi switch and not have an effect toggle.

Alternatively, there could just be two boxes for the user to enter values for off and on with the default being "always toggle" if both boxes are left blank, examples:
off: , on: -> "always toggle"
off: 0 on: 127
off: 127 on: 0
off: 0 on: 64
etc...

What do you think?

tramp
Established Member
Posts: 1616
Joined: Mon Jul 01, 2013 8:13 am

Re: Guitarix MIDI Output -> MIDI Foot Controller

Post by tramp »

arman wrote:
Sat May 23, 2020 9:52 pm
"always toggle" solves the double clicking problem but requires the effect to be saved in the opposite of the desired state. So if you want the effect to start off when the preset is switched to, you must save it in the on state and vice versa. In other words, "always toggle" seems to toggle the state for a preset change.
Ah, yes, it was a quick inclusion without much testing, have fix it now.
arman wrote:
Sat May 23, 2020 9:52 pm
Also, if this quirk is fixed I think this would actually be the only midi setting of the four that makes sense. I can't see a case where a user would want to hit their midi switch and not have an effect toggle.
Oh, all those modes been included on user requirements.
Most midi controllers been configured as push buttons, means they send 127 when pushed. That is the default "on/off state transition toggle" option. Then "constant state toggle" is for controller which send 127 when pushed and 0 when released. For example "Note On/Off" keys could be used here. "toggle state" is for controllers which send like yours 127 on the first push and 0 and the next. Also knob controller could be used with this.
Here the state >62< will be reflected.
And now the new "always toggle" special for the MIDI Commander which toggle on any message, regardless the sate of the controller and regardless the value of the message.
On the road again.

arman
Established Member
Posts: 16
Joined: Tue May 05, 2020 9:16 pm

Re: Guitarix MIDI Output -> MIDI Foot Controller

Post by arman »

tramp wrote:
Sun May 24, 2020 3:36 am
Ah, yes, it was a quick inclusion without much testing, have fix it now.
Save issue is resolved! Thanks very much!
Most midi controllers been configured as push buttons, means they send 127 when pushed. That is the default "on/off state transition toggle" option. Then "constant state toggle" is for controller which send 127 when pushed and 0 when released. For example "Note On/Off" keys could be used here. "toggle state" is for controllers which send like yours 127 on the first push and 0 and the next. Also knob controller could be used with this.
"constant state toggle" makes sense to me, I forgot some controllers send 127 when pushed and 0 on release.

"toggle state" - I can see why this would be necessary for knob type controllers.

As for "on/off state transition toggle", I believe "always toggle" now serves the same purpose. Midi Commander has a setting to only send 127 which I tested and "always toggle" works the same but "on/off state transition toggle" actually does nothing. With alternating 0 127, it requires a double tap for the state to change which is to be expected.

In any case, if it helps I would be happy to update the documentation now that I understand what the options are for! How could I do so?

tramp
Established Member
Posts: 1616
Joined: Mon Jul 01, 2013 8:13 am

Re: Guitarix MIDI Output -> MIDI Foot Controller

Post by tramp »

arman wrote:
Sun May 24, 2020 5:13 am
As for "on/off state transition toggle", I believe "always toggle" now serves the same purpose.
Not really, when a controller sends a stream (like a expression pedal) the always toggle option wouldn't work.
arman wrote:
Sun May 24, 2020 5:13 am
In any case, if it helps I would be happy to update the documentation now that I understand what the options are for! How could I do so?
Update is a bit understated, there is simply now documentation for the guitarix midi features. :oops:
It would be very welcome when you would write them.
You'll find my e-mail in the about box from guitarix, I'm hermann. When you send it to me, I'll work them in as help page.
On the road again.

arman
Established Member
Posts: 16
Joined: Tue May 05, 2020 9:16 pm

Re: Guitarix MIDI Output -> MIDI Foot Controller

Post by arman »

Will do!

I've noticed that using my expression pedal to control the volume effect's gain causes guitarix to close in version 0.39.0 (sourceforge) and the latest one from git. It doesn't do this when running 0.36.1.

I've uninstalled and reinstalled a few times with each version to be sure I'm not going nuts lol. I've looked at the messages from jack and nothing peculiar happens (DSP load, or xruns, etc), have even tried running with a higher frame rate. I didn't change anything with the expression pedals settings. Any idea what could be happening?

System is Raspbian gnu/linux 10

tramp
Established Member
Posts: 1616
Joined: Mon Jul 01, 2013 8:13 am

Re: Guitarix MIDI Output -> MIDI Foot Controller

Post by tramp »

arman wrote:
Mon May 25, 2020 12:46 am
Any idea what could be happening?
Yes, I've a report on github about that and was able to reproduce and fix it today.
Please update your checkout and let me know if it works for you as well.
arman wrote:
Mon May 25, 2020 12:46 am
I've looked at the messages from jack and nothing peculiar happens (DSP load, or xruns, etc)
It happens because the midi messages value changes been to fast for GTK. I've now implement a interval (60ms) to send the new values to the GUI, while using the values direct in the engine. So we've direct audible feedback, but the GUI have enough time to finish drawing before a new value arrive.
Visually you can't notice that anyway.
On the road again.

arman
Established Member
Posts: 16
Joined: Tue May 05, 2020 9:16 pm

Re: Guitarix MIDI Output -> MIDI Foot Controller

Post by arman »

tramp wrote:
Mon May 25, 2020 6:32 am
arman wrote:
Mon May 25, 2020 12:46 am
Any idea what could be happening?
Yes, I've a report on github about that and was able to reproduce and fix it today.
Please update your checkout and let me know if it works for you as well.
arman wrote:
Mon May 25, 2020 12:46 am
I've looked at the messages from jack and nothing peculiar happens (DSP load, or xruns, etc)
It happens because the midi messages value changes been to fast for GTK. I've now implement a interval (60ms) to send the new values to the GUI, while using the values direct in the engine. So we've direct audible feedback, but the GUI have enough time to finish drawing before a new value arrive.
Visually you can't notice that anyway.
Ah I see, that makes sense - 60 ms seems fair even with two controllers. I'm testing this version now and so far so good, thanks

Post Reply