Page 1 of 1

Directed choke issue in 0.9.19?

Posted: Fri Jan 08, 2021 6:42 pm
by JamesPeters
I noticed today, using 0.9.19, that the ability to choke the open hihat doesn't seem to work anymore for my kit, which uses directed choke for the hihats (any closed hit hihat "instrument" will choke any open hit hihat "instrument"). My kit file is based on the code from when directed choke functionality was introduced in 0.9.17 as documented in the changelog at that time. It worked in the previous DrumGizmo version 0.9.18. Is directed choke functionality accomplished differently now (would I have to alter the kit file's code)?

I'm using the Linux VST version of DrumGizmo that I built myself, in Reaper for Linux. Hopefully it has nothing to do with the fact I built it myself (incorrectly), but I've never had a problem with versions I've built myself.

Here's an example of the XML structure I'm using:

Code: Select all

 <instrument name="hihat_zild_clo" file="kitpieces/hihat_14_zildjian_k_custom_hybrid/hihat_zild_clo.xml">
    <chokes>
    	<choke instrument="hihat_zild_op1" choketime="30"/>
   	<choke instrument="hihat_zild_op1_edg" choketime="30"/>
   	<choke instrument="hihat_zild_op2" choketime="30"/>
   	<choke instrument="hihat_zild_op2_edg" choketime="30"/>
   	<choke instrument="hihat_zild_op3" choketime="30"/>
    	<choke instrument="hihat_zild_op3_edg" choketime="30"/>
    	<choke instrument="hihat_zild_spl" choketime="30"/>
    </chokes>
    <channelmap in="HIHAT" out="HIHAT"/>
    <channelmap in="HIHAT_OH_L" out="HIHAT_OH_L"/>
    <channelmap in="HIHAT_OH_R" out="HIHAT_OH_R"/>
    <channelmap in="HIHAT_ROOM_L" out="HIHAT_ROOM_L"/>
    <channelmap in="HIHAT_ROOM_R" out="HIHAT_ROOM_R"/>
  </instrument>

Re: Directed choke issue in 0.9.19?

Posted: Fri Jan 08, 2021 7:04 pm
by deva
It sounds like you have found a regression error. I will try to reproduce it and get back to you.

Re: Directed choke issue in 0.9.19?

Posted: Fri Jan 08, 2021 7:30 pm
by deva
I have found and fixed the bug on the git develop branch:
http://cgit.drumgizmo.org/drumgizmo.git ... 6ffa0d784f

Thank you very much for reporting the issue :-)

Re: Directed choke issue in 0.9.19?

Posted: Sun Jun 27, 2021 7:10 pm
by JamesPeters
This fix works of course. Thanks!

However, someone just messaged me on another forum saying my drumkit doesn't work for chokes. :) They're using 0.9.19 as it was officially released (without this fix).

I know you want to wait to release 0.9.20 as a bugfix release, but since that could still take a while, would you consider releasing a "hotfix" of 0.9.19 as it currently stands in your development branch? I can tell people to use 0.9.18 for now, but there have been a number of improvements and bugfixes since 0.9.18.

Re: Directed choke issue in 0.9.19?

Posted: Thu Jul 01, 2021 4:13 pm
by deva
I hope to be able to do a release during my summer vacation, which is starting about now.

Re: Directed choke issue in 0.9.19?

Posted: Wed Nov 17, 2021 8:03 am
by MrHaroldA
deva wrote: Thu Jul 01, 2021 4:13 pm I hope to be able to do a release during my summer vacation, which is starting about now.
I guess this never happened? ;) I do hope you had a nice vacation!

Re: Directed choke issue in 0.9.19?

Posted: Wed Nov 24, 2021 5:47 pm
by deva
MrHaroldA wrote: Wed Nov 17, 2021 8:03 am
deva wrote: Thu Jul 01, 2021 4:13 pm I hope to be able to do a release during my summer vacation, which is starting about now.
I guess this never happened? ;) I do hope you had a nice vacation!
So true - life got in the way I suppose