Directed choke issue in 0.9.19?

Moderators: MattKingUSA, khz, muldjord, deva

Post Reply
JamesPeters
Established Member
Posts: 188
Joined: Fri Jun 29, 2018 6:35 pm
Has thanked: 8 times
Been thanked: 15 times

Directed choke issue in 0.9.19?

Post by JamesPeters »

I noticed today, using 0.9.19, that the ability to choke the open hihat doesn't seem to work anymore for my kit, which uses directed choke for the hihats (any closed hit hihat "instrument" will choke any open hit hihat "instrument"). My kit file is based on the code from when directed choke functionality was introduced in 0.9.17 as documented in the changelog at that time. It worked in the previous DrumGizmo version 0.9.18. Is directed choke functionality accomplished differently now (would I have to alter the kit file's code)?

I'm using the Linux VST version of DrumGizmo that I built myself, in Reaper for Linux. Hopefully it has nothing to do with the fact I built it myself (incorrectly), but I've never had a problem with versions I've built myself.

Here's an example of the XML structure I'm using:

Code: Select all

 <instrument name="hihat_zild_clo" file="kitpieces/hihat_14_zildjian_k_custom_hybrid/hihat_zild_clo.xml">
    <chokes>
    	<choke instrument="hihat_zild_op1" choketime="30"/>
   	<choke instrument="hihat_zild_op1_edg" choketime="30"/>
   	<choke instrument="hihat_zild_op2" choketime="30"/>
   	<choke instrument="hihat_zild_op2_edg" choketime="30"/>
   	<choke instrument="hihat_zild_op3" choketime="30"/>
    	<choke instrument="hihat_zild_op3_edg" choketime="30"/>
    	<choke instrument="hihat_zild_spl" choketime="30"/>
    </chokes>
    <channelmap in="HIHAT" out="HIHAT"/>
    <channelmap in="HIHAT_OH_L" out="HIHAT_OH_L"/>
    <channelmap in="HIHAT_OH_R" out="HIHAT_OH_R"/>
    <channelmap in="HIHAT_ROOM_L" out="HIHAT_ROOM_L"/>
    <channelmap in="HIHAT_ROOM_R" out="HIHAT_ROOM_R"/>
  </instrument>
User avatar
deva
Established Member
Posts: 285
Joined: Sun Oct 23, 2016 10:15 am
Has thanked: 3 times
Been thanked: 31 times
Contact:

Re: Directed choke issue in 0.9.19?

Post by deva »

It sounds like you have found a regression error. I will try to reproduce it and get back to you.
User avatar
deva
Established Member
Posts: 285
Joined: Sun Oct 23, 2016 10:15 am
Has thanked: 3 times
Been thanked: 31 times
Contact:

Re: Directed choke issue in 0.9.19?

Post by deva »

I have found and fixed the bug on the git develop branch:
http://cgit.drumgizmo.org/drumgizmo.git ... 6ffa0d784f

Thank you very much for reporting the issue :-)
JamesPeters
Established Member
Posts: 188
Joined: Fri Jun 29, 2018 6:35 pm
Has thanked: 8 times
Been thanked: 15 times

Re: Directed choke issue in 0.9.19?

Post by JamesPeters »

This fix works of course. Thanks!

However, someone just messaged me on another forum saying my drumkit doesn't work for chokes. :) They're using 0.9.19 as it was officially released (without this fix).

I know you want to wait to release 0.9.20 as a bugfix release, but since that could still take a while, would you consider releasing a "hotfix" of 0.9.19 as it currently stands in your development branch? I can tell people to use 0.9.18 for now, but there have been a number of improvements and bugfixes since 0.9.18.
User avatar
deva
Established Member
Posts: 285
Joined: Sun Oct 23, 2016 10:15 am
Has thanked: 3 times
Been thanked: 31 times
Contact:

Re: Directed choke issue in 0.9.19?

Post by deva »

I hope to be able to do a release during my summer vacation, which is starting about now.
MrHaroldA
Established Member
Posts: 4
Joined: Tue May 23, 2017 8:13 am
Has thanked: 1 time

Re: Directed choke issue in 0.9.19?

Post by MrHaroldA »

deva wrote: Thu Jul 01, 2021 4:13 pm I hope to be able to do a release during my summer vacation, which is starting about now.
I guess this never happened? ;) I do hope you had a nice vacation!
User avatar
deva
Established Member
Posts: 285
Joined: Sun Oct 23, 2016 10:15 am
Has thanked: 3 times
Been thanked: 31 times
Contact:

Re: Directed choke issue in 0.9.19?

Post by deva »

MrHaroldA wrote: Wed Nov 17, 2021 8:03 am
deva wrote: Thu Jul 01, 2021 4:13 pm I hope to be able to do a release during my summer vacation, which is starting about now.
I guess this never happened? ;) I do hope you had a nice vacation!
So true - life got in the way I suppose
Post Reply