Directed choke issue in 0.9.19?

Moderators: khz, MattKingUSA, deva, muldjord

Post Reply
JamesPeters
Established Member
Posts: 142
Joined: Fri Jun 29, 2018 6:35 pm
Contact:

Directed choke issue in 0.9.19?

Post by JamesPeters »

I noticed today, using 0.9.19, that the ability to choke the open hihat doesn't seem to work anymore for my kit, which uses directed choke for the hihats (any closed hit hihat "instrument" will choke any open hit hihat "instrument"). My kit file is based on the code from when directed choke functionality was introduced in 0.9.17 as documented in the changelog at that time. It worked in the previous DrumGizmo version 0.9.18. Is directed choke functionality accomplished differently now (would I have to alter the kit file's code)?

I'm using the Linux VST version of DrumGizmo that I built myself, in Reaper for Linux. Hopefully it has nothing to do with the fact I built it myself (incorrectly), but I've never had a problem with versions I've built myself.

Here's an example of the XML structure I'm using:

Code: Select all

 <instrument name="hihat_zild_clo" file="kitpieces/hihat_14_zildjian_k_custom_hybrid/hihat_zild_clo.xml">
    <chokes>
    	<choke instrument="hihat_zild_op1" choketime="30"/>
   	<choke instrument="hihat_zild_op1_edg" choketime="30"/>
   	<choke instrument="hihat_zild_op2" choketime="30"/>
   	<choke instrument="hihat_zild_op2_edg" choketime="30"/>
   	<choke instrument="hihat_zild_op3" choketime="30"/>
    	<choke instrument="hihat_zild_op3_edg" choketime="30"/>
    	<choke instrument="hihat_zild_spl" choketime="30"/>
    </chokes>
    <channelmap in="HIHAT" out="HIHAT"/>
    <channelmap in="HIHAT_OH_L" out="HIHAT_OH_L"/>
    <channelmap in="HIHAT_OH_R" out="HIHAT_OH_R"/>
    <channelmap in="HIHAT_ROOM_L" out="HIHAT_ROOM_L"/>
    <channelmap in="HIHAT_ROOM_R" out="HIHAT_ROOM_R"/>
  </instrument>

User avatar
deva
Established Member
Posts: 186
Joined: Sun Oct 23, 2016 10:15 am
Contact:

Re: Directed choke issue in 0.9.19?

Post by deva »

It sounds like you have found a regression error. I will try to reproduce it and get back to you.

User avatar
deva
Established Member
Posts: 186
Joined: Sun Oct 23, 2016 10:15 am
Contact:

Re: Directed choke issue in 0.9.19?

Post by deva »

I have found and fixed the bug on the git develop branch:
http://cgit.drumgizmo.org/drumgizmo.git ... 6ffa0d784f

Thank you very much for reporting the issue :-)

JamesPeters
Established Member
Posts: 142
Joined: Fri Jun 29, 2018 6:35 pm
Contact:

Re: Directed choke issue in 0.9.19?

Post by JamesPeters »

I modified the file based on that info and built it again. It works now! Thanks!

Post Reply