Dragonfly Hall Reverb

All your LV2 and LADSPA goodness and more.

Moderators: MattKingUSA, khz

Post Reply
User avatar
GMaq
Established Member
Posts: 2774
Joined: Fri Sep 25, 2009 1:42 pm
Has thanked: 520 times
Been thanked: 555 times

Re: Dragonfly Hall Reverb

Post by GMaq »

rghvdberg wrote:I'd be honoured :-)

Still some bits and bobs to add on this reverb.
If my latest pr is merged I'll need some testers to confirm the font issues are fixed.
Then it's time to finally put in the response graphics , I think.

Ninjas needs testers too, some audio files crash the plugin but I've been unable to reproduce on other systems.
The honour is all mine! :wink:

You guys are the chefs, I'm just the waiter. Sincere thanks to all our talented Linux Audio developers old and new for your generosity, time and talents given to the community! 8) :D

I'll wait awhile longer to let the Reverb and Ninjas settle into a plateau release, thanks again!
ssj71
Established Member
Posts: 1294
Joined: Tue Sep 25, 2012 6:36 pm
Has thanked: 1 time

Re: Dragonfly Hall Reverb

Post by ssj71 »

This is quite possibly the most collaborative thread I've ever seen here! ;)
_ssj71

music: https://soundcloud.com/ssj71
My plugins are Infamous! http://ssj71.github.io/infamousPlugins
I just want to get back to making music!
User avatar
davephillips
Established Member
Posts: 592
Joined: Sat Aug 15, 2015 1:05 pm
Has thanked: 35 times
Been thanked: 23 times

Re: Dragonfly Hall Reverb

Post by davephillips »

rghvdberg wrote:...
If my latest pr is merged I'll need some testers to confirm the font issues are fixed.
Then it's time to finally put in the response graphics , I think.
...
Looking good now, Rob. I built the latest code from Michael's repo, the label/fonts issues are gone, and no more assertion error. I tested the standalone and the VST (in Bitwig 2.3), everything seems very stable now. Sounds good too. :)

Best,

dp
User avatar
Michael Willis
Established Member
Posts: 1451
Joined: Mon Oct 03, 2016 3:27 pm
Location: Rocky Mountains, North America
Has thanked: 69 times
Been thanked: 163 times
Contact:

Re: Dragonfly Hall Reverb

Post by Michael Willis »

davephillips wrote:Sounds good too. :)
Thanks for testing it again, Dave. Do you have an opinion on the presets' default wet levels? In the past I've had people tell me that I put on way too much reverb, so while I've been developing this plugin I opted for subtlety in the presets, but then I had somebody test the plugin and report their opinion that the default reverb levels are too low. I'm inclined to bump up the late levels by five percent, and maybe some of the early levels too, but I would like some more opinions first.
User avatar
Michael Willis
Established Member
Posts: 1451
Joined: Mon Oct 03, 2016 3:27 pm
Location: Rocky Mountains, North America
Has thanked: 69 times
Been thanked: 163 times
Contact:

Re: Dragonfly Hall Reverb

Post by Michael Willis »

Also, Freeverb3 has a different algorithm that it claims is better for a small room sound. I'm getting an itch to develop a sister plugin that uses the room algorithm, which has some very different parameters than this one. Maybe it could be called "Damselfly" (insect related to dragonfly). Would anybody be interested in such?
finotti
Established Member
Posts: 528
Joined: Thu Sep 01, 2011 9:07 pm
Has thanked: 86 times
Been thanked: 23 times

Re: Dragonfly Hall Reverb

Post by finotti »

I'd say the more the merrier, but I don't have to do any work, so... :-)

Thanks for your work!
User avatar
sysrqer
Established Member
Posts: 2519
Joined: Thu Nov 14, 2013 11:47 pm
Has thanked: 319 times
Been thanked: 148 times
Contact:

Re: Dragonfly Hall Reverb

Post by sysrqer »

Definitely would be interested.
User avatar
GMaq
Established Member
Posts: 2774
Joined: Fri Sep 25, 2009 1:42 pm
Has thanked: 520 times
Been thanked: 555 times

Re: Dragonfly Hall Reverb

Post by GMaq »

sysrqer wrote:Definitely would be interested.
+1
rghvdberg
Established Member
Posts: 1067
Joined: Mon May 12, 2014 7:11 am
Has thanked: 15 times
Been thanked: 36 times

Re: Dragonfly Hall Reverb

Post by rghvdberg »

Michael Willis wrote:Also, Freeverb3 has a different algorithm that it claims is better for a small room sound. I'm getting an itch to develop a sister plugin that uses the room algorithm, which has some very different parameters than this one. Maybe it could be called "Damselfly" (insect related to dragonfly). Would anybody be interested in such?
Are you talking about the ProG reverb?
I've used that multiple times.
So yes

And if it's another one.
Yes.

Btw, would it be possible to get them both in one plugin?
User avatar
Michael Willis
Established Member
Posts: 1451
Joined: Mon Oct 03, 2016 3:27 pm
Location: Rocky Mountains, North America
Has thanked: 69 times
Been thanked: 163 times
Contact:

Re: Dragonfly Hall Reverb

Post by Michael Willis »

rghvdberg wrote:Are you talking about the ProG reverb?
I've used that multiple times.
So yes
And if it's another one. Yes.
So the answer is either yes, or yes. I'll take that as a yes. Yes, I meant ProG.
rghvdberg wrote:Btw, would it be possible to get them both in one plugin?
Heh, I would love to get them both in one plugin. The parameters to ProG are different than the parameters to Hibiki, so we would have to consider whether there is a good way for one plugin to accommodate both algorithms. Let's wrap up version 1 of this one first though, then we can decide what to do with ProG.
rghvdberg
Established Member
Posts: 1067
Joined: Mon May 12, 2014 7:11 am
Has thanked: 15 times
Been thanked: 36 times

Re: Dragonfly Hall Reverb

Post by rghvdberg »

Okidoki.

Gonna be a few days till I got time to work on the graph btw.
User avatar
davephillips
Established Member
Posts: 592
Joined: Sat Aug 15, 2015 1:05 pm
Has thanked: 35 times
Been thanked: 23 times

Re: Dragonfly Hall Reverb

Post by davephillips »

Michael Willis wrote:... Do you have an opinion on the presets' default wet levels? In the past I've had people tell me that I put on way too much reverb, so while I've been developing this plugin I opted for subtlety in the presets, but then I had somebody test the plugin and report their opinion that the default reverb levels are too low. I'm inclined to bump up the late levels by five percent, and maybe some of the early levels too, but I would like some more opinions first.
Hi Michael,

I like the sound now but agree that you could raise the early and late levels a bit without adverse effect.

dp
rghvdberg
Established Member
Posts: 1067
Joined: Mon May 12, 2014 7:11 am
Has thanked: 15 times
Been thanked: 36 times

Re: Dragonfly Hall Reverb

Post by rghvdberg »

Finally got the labels in the Response tab sorted
x-axis : frequencies, y-axis; time in seconds.

We were struggling with the correct math stuff to position the labels.
I was looking at other plugins and how they looked. I noticed fil4.lv2 had the labelling how we wanted it to be.
Image

So I cloned the repo (https://github.com/x42/fil4.lv2.git) and imported it in Kdevelop.
Then the hunt was on, where is the code that draws the labels.
I noticed tools/gen_image.c
Lot's of frequency printing stuff in there (dial_to_freq (const FilterFreq *m, float f) for example), but couldn't find the 20 - 20k labels.

Then I saw gui/fil4.c .
Wait,gui,these labels must be in the gui .
Kdevelop has the feauture when you hover over a statement, a little pop-up shows up where you can 'trace' the use of a function/variable.
Image
Following "Show Uses" it turned out this was indeed the function I needed.
I 'copied' the function in Libreoffice Calc and found it gave the desired output.

One small problem , it only looked good when starting with 20 ..

Later on irc (#lad, freenode) rgareus (aka x42) told me the general function is

Code: Select all

x =  log ( f / minimum ) / log ( maximum / minimum ) 
if f = minimum -> x = 0
if f = maximum -> x = 1
Now it made sense, fil4.lv2 has a range of 20 - 20K

Code: Select all

return rintf(m0_width * logf (f / 20.0) / logf (1000.0));
20 is the minimum, 20000 is maximum -> 1000 = 20000/20 .. duh .. :roll:

So I needed :

Code: Select all

int x = ( int ) ( pixel_width * logf ( freq[i] / 50.0f ) / logf ( 20000.0f / 50.0f )
The result (layout tweaking needed ofc):
Image

(I'm very proud and feel very smart :p )
barbouze
Established Member
Posts: 186
Joined: Tue May 26, 2015 12:26 pm
Has thanked: 2 times
Been thanked: 16 times

Re: Dragonfly Hall Reverb

Post by barbouze »

That post is a fine example of open source at its best. Keep going, this looks promising! :D
User avatar
Michael Willis
Established Member
Posts: 1451
Joined: Mon Oct 03, 2016 3:27 pm
Location: Rocky Mountains, North America
Has thanked: 69 times
Been thanked: 163 times
Contact:

Re: Dragonfly Hall Reverb

Post by Michael Willis »

rghvdberg wrote:Finally got the labels in the Response tab sorted
Nice!

Currently it is possible to get decay times longer than 10 seconds. I cheated a little bit and made the mid-range decay time just the room size divided by 20. If you make the room size 100 meters, the mid-range decay is 5 seconds, and then if you have a low multiplier of 3.0, the low frequencies will decay in 15 seconds.

You could argue that such a long rumbling low decay is kind of ludicrous and not very useful; this is one of those matters of how much freedom to give the user vs. making a reverb plugin that satisfies some specific uses very well.
Post Reply