Dragonfly Hall Reverb

All your LV2 and LADSPA goodness and more.

Moderators: khz, MattKingUSA

User avatar
Michael Willis
Establlshed Member
Posts: 491
Joined: Mon Oct 03, 2016 3:27 pm

Re: Dragonfly Hall Reverb

Postby Michael Willis » Tue Mar 13, 2018 9:59 pm

rghvdberg wrote:Are you talking about the ProG reverb?
I've used that multiple times.
So yes
And if it's another one. Yes.

So the answer is either yes, or yes. I'll take that as a yes. Yes, I meant ProG.

rghvdberg wrote:Btw, would it be possible to get them both in one plugin?

Heh, I would love to get them both in one plugin. The parameters to ProG are different than the parameters to Hibiki, so we would have to consider whether there is a good way for one plugin to accommodate both algorithms. Let's wrap up version 1 of this one first though, then we can decide what to do with ProG.

rghvdberg
Establlshed Member
Posts: 718
Joined: Mon May 12, 2014 7:11 am

Re: Dragonfly Hall Reverb

Postby rghvdberg » Tue Mar 13, 2018 11:22 pm

Okidoki.

Gonna be a few days till I got time to work on the graph btw.

User avatar
davephillips
Establlshed Member
Posts: 406
Joined: Sat Aug 15, 2015 1:05 pm

Re: Dragonfly Hall Reverb

Postby davephillips » Wed Mar 14, 2018 12:00 pm

Michael Willis wrote:... Do you have an opinion on the presets' default wet levels? In the past I've had people tell me that I put on way too much reverb, so while I've been developing this plugin I opted for subtlety in the presets, but then I had somebody test the plugin and report their opinion that the default reverb levels are too low. I'm inclined to bump up the late levels by five percent, and maybe some of the early levels too, but I would like some more opinions first.


Hi Michael,

I like the sound now but agree that you could raise the early and late levels a bit without adverse effect.

dp

rghvdberg
Establlshed Member
Posts: 718
Joined: Mon May 12, 2014 7:11 am

Re: Dragonfly Hall Reverb

Postby rghvdberg » Thu Mar 15, 2018 9:36 am

Finally got the labels in the Response tab sorted
x-axis : frequencies, y-axis; time in seconds.

We were struggling with the correct math stuff to position the labels.
I was looking at other plugins and how they looked. I noticed fil4.lv2 had the labelling how we wanted it to be.
Image

So I cloned the repo (https://github.com/x42/fil4.lv2.git) and imported it in Kdevelop.
Then the hunt was on, where is the code that draws the labels.
I noticed tools/gen_image.c
Lot's of frequency printing stuff in there (dial_to_freq (const FilterFreq *m, float f) for example), but couldn't find the 20 - 20k labels.

Then I saw gui/fil4.c .
Wait,gui,these labels must be in the gui .
Kdevelop has the feauture when you hover over a statement, a little pop-up shows up where you can 'trace' the use of a function/variable.
Image
Following "Show Uses" it turned out this was indeed the function I needed.
I 'copied' the function in Libreoffice Calc and found it gave the desired output.

One small problem , it only looked good when starting with 20 ..

Later on irc (#lad, freenode) rgareus (aka x42) told me the general function is

Code: Select all

x =  log ( f / minimum ) / log ( maximum / minimum )

if f = minimum -> x = 0
if f = maximum -> x = 1
Now it made sense, fil4.lv2 has a range of 20 - 20K

Code: Select all

return rintf(m0_width * logf (f / 20.0) / logf (1000.0));

20 is the minimum, 20000 is maximum -> 1000 = 20000/20 .. duh .. :roll:

So I needed :

Code: Select all

int x = ( int ) ( pixel_width * logf ( freq[i] / 50.0f ) / logf ( 20000.0f / 50.0f )


The result (layout tweaking needed ofc):
Image

(I'm very proud and feel very smart :p )

barbouze
Establlshed Member
Posts: 140
Joined: Tue May 26, 2015 12:26 pm

Re: Dragonfly Hall Reverb

Postby barbouze » Thu Mar 15, 2018 9:47 am

That post is a fine example of open source at its best. Keep going, this looks promising! :D

User avatar
Michael Willis
Establlshed Member
Posts: 491
Joined: Mon Oct 03, 2016 3:27 pm

Re: Dragonfly Hall Reverb

Postby Michael Willis » Thu Mar 15, 2018 5:23 pm

rghvdberg wrote:Finally got the labels in the Response tab sorted


Nice!

Currently it is possible to get decay times longer than 10 seconds. I cheated a little bit and made the mid-range decay time just the room size divided by 20. If you make the room size 100 meters, the mid-range decay is 5 seconds, and then if you have a low multiplier of 3.0, the low frequencies will decay in 15 seconds.

You could argue that such a long rumbling low decay is kind of ludicrous and not very useful; this is one of those matters of how much freedom to give the user vs. making a reverb plugin that satisfies some specific uses very well.

ssj71
Establlshed Member
Posts: 1240
Joined: Tue Sep 25, 2012 6:36 pm

Re: Dragonfly Hall Reverb

Postby ssj71 » Thu Mar 15, 2018 7:15 pm

Michael Willis wrote:You could argue that such a long rumbling low decay is kind of ludicrous and not very useful; this is one of those matters of how much freedom to give the user vs. making a reverb plugin that satisfies some specific uses very well.


I think it would be fine to allow longer times but not show them in the UI. Especially if gradients are used in the graph you'll get the idea that the decay is "off the charts" :)
_ssj71

music: https://soundcloud.com/ssj71
My plugins are Infamous! http://ssj71.github.io/infamousPlugins
I just want to get back to making music!

rghvdberg
Establlshed Member
Posts: 718
Joined: Mon May 12, 2014 7:11 am

Re: Dragonfly Hall Reverb

Postby rghvdberg » Thu Mar 15, 2018 7:52 pm

Pretty easy to scale the labels to the actual max decay time.

Long reverbs on 'drops' ... Love it.

User avatar
Michael Willis
Establlshed Member
Posts: 491
Joined: Mon Oct 03, 2016 3:27 pm

Re: Dragonfly Hall Reverb

Postby Michael Willis » Sat Mar 31, 2018 10:38 pm

Here's a peek at the latest version:
Image
I'm getting really close to making a v1.0 release, there are just a few more bugs to fix.

finotti
Establlshed Member
Posts: 265
Joined: Thu Sep 01, 2011 9:07 pm

Re: Dragonfly Hall Reverb

Postby finotti » Sun Apr 01, 2018 12:10 am

Michael Willis wrote:Here's a peek at the latest version:
Image
I'm getting really close to making a v1.0 release, there are just a few more bugs to fix.


Nice! Looks great! Thanks for your work on this!

User avatar
davephillips
Establlshed Member
Posts: 406
Joined: Sat Aug 15, 2015 1:05 pm

Re: Dragonfly Hall Reverb

Postby davephillips » Sun Apr 01, 2018 12:12 am

Michael Willis wrote:Here's a peek at the latest version:


Looking good !

I built the latest git pull, but I had to add -lpthread to some of the last stages, I'll do a clean build again and leave an issue for you on git.

Best,

dp

User avatar
Michael Willis
Establlshed Member
Posts: 491
Joined: Mon Oct 03, 2016 3:27 pm

Re: Dragonfly Hall Reverb

Postby Michael Willis » Sun Apr 01, 2018 2:49 am

davephillips wrote:I built the latest git pull, but I had to add -lpthread to some of the last stages, I'll do a clean build again and leave an issue for you on git.


Thanks Dave. Sorry for the trouble, like I've mentioned before I do a lot of the development on a mac laptop, so when I switch between building on mac and linux there are often little changes that have to be made to the make files.

If you're familiar enough with git, will you submit a pull request with the -lpthread fix?

Also, to be transparent, here are the three bugs I'm still working on:

1. When the UI is first displayed, the spectrogram is blank. It doesn't show until a preset is picked, even if you load it from a saved DAW session that already had a preset picked.

2. Sometimes the spectrogram will end up in a state that it displays as a completely saturated rectangle. I think to reproduce this, show the plugin interface, pick a preset and quickly switch to the spectrogram view.

3. The spectrogram doesn't always stay in sync with the latest settings of the dials. This is particularly obvious when quickly turning a dial all the way from low to high (or vice versa). The spectrogram won't be correct, but if you then slightly adjust any knob at all, the spectrogram will update again and be mostly correct.

My guess is that all of these are problems with thread concurrency, since it uses a separate thread to render the spectrogram asynchronously (so as not to hang up the UI). I tried to be careful with the implementation, using the Signal class to communicate, but there are a number of places in the code where both threads read the same data. If anybody here with experience programming multithreaded c++ could take a look and help, that would be fantastic, otherwise I'll try to figure it out on my own.

User avatar
Michael Willis
Establlshed Member
Posts: 491
Joined: Mon Oct 03, 2016 3:27 pm

Re: Dragonfly Hall Reverb

Postby Michael Willis » Sun Apr 01, 2018 3:57 am

Make that four bugs... rghvdberg already reported that it crashes on exit, because the Spectrogram thread doesn't properly terminate: https://github.com/michaelwillis/dragon ... /issues/19

User avatar
Michael Willis
Establlshed Member
Posts: 491
Joined: Mon Oct 03, 2016 3:27 pm

Re: Dragonfly Hall Reverb

Postby Michael Willis » Mon Apr 02, 2018 2:52 pm

davephillips wrote:-lpthread


Fixed.

User avatar
falkTX
Establlshed Member
Posts: 6645
Joined: Sat Jan 09, 2010 3:04 pm

Re: Dragonfly Hall Reverb

Postby falkTX » Mon Apr 02, 2018 4:31 pm

I see people are abusing the makefiles in weird ways... :lol:
Before you do an official 1.0 release, ping me so I can review the project a little.
I'll go through the code and files to make sure things are generally done in a good way. Thanks.


Return to “Plugins, Effects and Instruments”

Who is online

Users browsing this forum: No registered users and 14 guests