just tried out the latest svn version of guitarix. Some improvements the more comprehensive setting for each effect is definitely a big plus!
however, there are some bugs :
1- click on the new button to pop up an effect setting window (let's say the freeverb setting window)
2- click on the same button again, the window disappears as expected
3- make it show up again like in step 1- but this time, make the window disappear via the windows manager, i.e. click on the little cross belonging to the window's upper bar
4- try to make the setting window come up again, it won't. The terminal reports some GTK error :
Code: Select all
(guitarix:16922): GLib-GObject-WARNING **: invalid uninstantiatable type `(null)' in cast to `GtkWindow'
(guitarix:16922): Gtk-CRITICAL **: gtk_window_move: assertion `GTK_IS_WINDOW (window)' failed
Other comments :
- is the effect chain order hardcoded ? can you swap effects (say the distorsion before the echo or vice-versa) ?
- you definitely miss a compressor / limiter on the output. I know you're working on converting guitarix into a LADSPA host, but if you deemed the distorsion, freeverb, etc important enough to have them natively in guitarix, I think an efficient compressor / limiter deserves the same treatment. Any comment on this ? or you prefer letting ppl use their favorite comp through the LADSPA import ?
Which makes me think about another thing : will you have a sort of window picturing the effect chain with possibilities to rearrange native and imported effects, and maybe more ? (a bit like jost or similar to patchage) But now, we get into complex stuff and that's not the ambition of guitarix. If you want to keep it simple, that's a good idea as well.