Page 9 of 10

Re: LSP Project

Posted: Mon Sep 02, 2019 9:30 pm
by sadko4u
lilith wrote:Still crashing:
I see still count being too huge: count=18446744073703159930
Have you properly rebuilt plugins? You need to issue:

Code: Select all

make clean
before you'll start any build.

Also, what's your audio settings - Sample rate, buffer size, etc?
Maybe I'll try to launch plugins with your settings.

Edit:
Also, please try this commit:
https://github.com/sadko4u/lsp-plugins/ ... 2edc7f4c25

It seems that there was a really buffer-overflow-related memory corruption.

Re: LSP Project

Posted: Mon Sep 02, 2019 9:44 pm
by lilith
sadko4u wrote:
lilith wrote:Still crashing:
I see still count being too huge: count=18446744073703159930
Have you properly rebuilt plugins? You need to issue:

Code: Select all

make clean
before you'll start any build.

Also, what's your audio settings - Sample rate, buffer size, etc?
Maybe I'll try to launch plugins with your settings.
Yes, I made "make clean" and "git checkout -b spectrum-analyzer origin/spectrum-analyzer".

I'm using 1056 samples @ 48 kHz and 3 periods/buffer.

Re: LSP Project

Posted: Mon Sep 02, 2019 9:51 pm
by sadko4u
lilith wrote: I'm using 1056 samples @ 48 kHz and 3 periods/buffer.
1056? It's non-standard power-of-two buffer size. Maybe it's related to such settings.

Anyway, please try this commit:
https://github.com/sadko4u/lsp-plugins/ ... 2edc7f4c25

It seems that there was a really buffer-overflow-related memory corruption.

Re: LSP Project

Posted: Mon Sep 02, 2019 9:53 pm
by lilith
sadko4u wrote:
lilith wrote: I'm using 1056 samples @ 48 kHz and 3 periods/buffer.
1056? It's non-standard power-of-two buffer size. Maybe it's related to such settings.

Anyway, please try this commit:
https://github.com/sadko4u/lsp-plugins/ ... 2edc7f4c25

It seems that there was a really buffer-overflow-related memory corruption.
It works better with my interface as it's a multiple of 48. I'll check again.

Re: LSP Project

Posted: Mon Sep 02, 2019 9:58 pm
by sadko4u
lilith wrote:It works better with my interface as it's a multiple of 48. I'll check again.
I've reproduced the bug using your samples/buffer settings. The latest patch should fix the problem.

Re: LSP Project

Posted: Mon Sep 02, 2019 9:59 pm
by lilith
sadko4u wrote:
lilith wrote:It works better with my interface as it's a multiple of 48. I'll check again.
I've reproduced the bug on your samples/buffer settings. The latest patch should fix the problem.
Great :) Thanks!

Re: LSP Project

Posted: Mon Sep 02, 2019 10:05 pm
by lilith
Solid like a rock now! :D

Re: LSP Project

Posted: Mon Sep 02, 2019 10:06 pm
by sadko4u
lilith wrote:Great :) Thanks!
The list of affected plugins by this bug: Parametric Equalizer, Graphic Equalizer, Spectrum Analyzer, Multiband Compressor.

Merged changes to devel branch.
Removed spectrum-analyzer branch.
Added patch to the hotfix branch which can be used as a patch source to the 1.1.10 release source code.
https://github.com/sadko4u/lsp-plugins/ ... 30072f9544

Re: LSP Project

Posted: Sun Sep 08, 2019 2:05 pm
by lilith
I'm a bit confused which branch to install now of the LSP plugins. Guess the recent bug fixes are not implemented in the master yet?
I also wanted to setup the parametric EQ, but I don't see any APO option in the mode. Maybe I'm missing the recent changes, because last time installed from the spectrum analyzer branch?

Re: LSP Project

Posted: Sun Sep 08, 2019 2:12 pm
by lilith
Also getting a crash when changing the mode paramter to eg FIR. Again with Desktop freeze. When I check the tmp folder from another console there's nothing written to it. So, likely a crash in Carla?

Image

Re: LSP Project

Posted: Sun Sep 08, 2019 4:22 pm
by lilith
I copied the LSP files from /home/marco/lib/vst to /home/marco/vst and now everything is working fine. Maybe a problem with Carla / Renoise as Renoise didn't find the VST path. Also the APO is back.

Re: LSP Project

Posted: Sun Sep 08, 2019 4:59 pm
by sadko4u
lilith wrote:I'm a bit confused which branch to install now of the LSP plugins. Guess the recent bug fixes are not implemented in the master yet?
I also wanted to setup the parametric EQ, but I don't see any APO option in the mode. Maybe I'm missing the recent changes, because last time installed from the spectrum analyzer branch?
You can use tags to fetch the latest release. For example, this is the 1.1.10 release:
https://github.com/sadko4u/lsp-plugins/ ... ins-1.1.10

If you want to get hot fixes to the latest release, you may checkout the hotfix branch which has master branch as a base:
https://github.com/sadko4u/lsp-plugins/tree/hotfix

If you want to get the actual development branch, you probably need to checkout the devel branch:
https://github.com/sadko4u/lsp-plugins/tree/devel

Re: LSP Project

Posted: Sun Sep 08, 2019 5:07 pm
by lilith
sadko4u wrote:
lilith wrote:I'm a bit confused which branch to install now of the LSP plugins. Guess the recent bug fixes are not implemented in the master yet?
I also wanted to setup the parametric EQ, but I don't see any APO option in the mode. Maybe I'm missing the recent changes, because last time installed from the spectrum analyzer branch?
You can use tags to fetch the latest release. For example, this is the 1.1.10 release:
https://github.com/sadko4u/lsp-plugins/ ... ins-1.1.10

If you want to get hot fixes to the latest release, you may checkout the hotfix branch which has master branch as a base:
https://github.com/sadko4u/lsp-plugins/tree/hotfix

If you want to get the actual development branch, you probably need to checkout the devel branch:
https://github.com/sadko4u/lsp-plugins/tree/devel
Thanks! Just have to get used more to git :)

Re: LSP Project

Posted: Sun Sep 15, 2019 11:51 am
by Capoeira
a output peak meter for plugins like EQs and convolvers would be very usefull

Re: LSP Project

Posted: Sun Sep 15, 2019 9:05 pm
by sadko4u
Capoeira wrote:a output peak meter for plugins like EQs and convolvers would be very usefull
For EQs there is already an output meter. For Convolvers... Maybe, if I find the proper place where to locate them.